Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Enable Gin's high contrast mode to improve accessibility #147

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Enable Gin's high contrast mode to improve accessibility #147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc1c884
Adding high contrast to gin config to improve a11y.
thegbomb Jul 26, 2024
70c36f7
Removing unchanged config.
thegbomb Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions recipes/starshot_admin_theme/recipe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ config:
gin: '*'
navigation: '*'
actions:
gin.settings:
simple_config_update:
high_contrast_mode: true
accent_color: ''
focus_color: ''
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question - why are the accent and focus colors removed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't set until the high contrast is enabled, when the setting is switched on, those values are set to an empty string and could be changed if necessary, the defaults are an improvement as they are, but I will consult others to see if a better setting could be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarrely, I double-checked where this came from by installing starshot and exporting the config.

I then switched on the high contrast toggle and exported again to see the diff. The accent and focus colours were not in the original export, but are added when the high contrast is switched on. There are other changes, but mostly just moving config up and down in the config file. I'll remove them as they seem to be set not changed.

system.theme:
simple_config_update:
admin: gin