Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Add login_emailusername #164

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Add login_emailusername #164

merged 2 commits into from
Aug 5, 2024

Conversation

phenaproxima
Copy link
Owner

@phenaproxima phenaproxima commented Aug 2, 2024

Logging in by username only is outmoded and inconvenient. Let's make it possible to login with your email address. I haven't personally used this module before but it has a solid install base and claims to be zero configuration.

I'll leave the final decision to commit to @pameeela or someone else who actually builds sites, but from a value perspective, in my personal opinion, this feels like the no-braineriest of no-brainers.

@phenaproxima
Copy link
Owner Author

The other module that might make sense for this is https://www.drupal.org/project/mail_login. Not sure which one is better, though. Mail Login has more installs, and seems more configurable, but I don't know how desirability more configuration options are in this case. I'd love to hear some input.

@phenaproxima
Copy link
Owner Author

https://www.drupal.org/project/email_registration is another one, with even more installs.

@pameeela
Copy link
Collaborator

pameeela commented Aug 5, 2024

I totally agree that logging in with your email address is a no-brainer. Personally, I always just use the email address as the username when creating accounts, so people don't have to remember yet another thing.

But how to resolve this is not that simple IMO. The simplest (from the perspective of what we already have) is to keep the username as a thing but also allow users to login using their email address, which login_emailusername and mail_login do. The other approach, and what email_registration does, is basically remove the username from the process altogether. For me that is a harder sell because it's kind of at odds with core?

Overall I am a huge +1 on this idea but not sure of the best approach. If we go with the first option, I would be in favour of no config required, just keep it simple.

Curious what others think!

@phenaproxima
Copy link
Owner Author

phenaproxima commented Aug 5, 2024

I definitely prefer something that's not "fighting" core. I don't think we need to remove usernames from the equation, at least not for now. But allowing login by email feels borderline essential.

@phenaproxima
Copy link
Owner Author

It's worth discussing which solution to use for the long term, but the beauty of recipes is that we can always change it later. In the meantime, though, this feature is so obviously useful that I think it makes more sense to ask for forgiveness than permission. I'll merge it.

@phenaproxima phenaproxima merged commit 9b40ced into main Aug 5, 2024
4 checks passed
@phenaproxima phenaproxima deleted the login-email branch August 5, 2024 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants