Set up a GitHub Actions workflow

[TravisCarden]

• Part One of Set up a GitHub Actions workflow #1

---

• Build the project the way it would be used in real life (via composer create-project, not just composer install)
• Test against PHP 8.1, 8.2, and 8.3
• Also against Ubuntu (macOS and Windows deferred to a follow-up)
• Run automatically...
  • every 12 hours
  • on pushes to main and wip
  • on PRs to main and develop
  • when triggered manually
• The web directory should be served by Apache

Notes

• Per discussion with you, macOS and Windows support have been deferred to an as-yet unprioritized follow-up issue.
• I configured it to run on pushes and pull requests, even though that wasn't explicitly in the requirements, because it seemed obvious and I assume you would want it.
• This doesn't install Nightwatch or any supplementary testing requirements, as they weren't in the success criteria. Obviously, they can be added in follow-ups as necessary.
• I assume that Apache is multi-threaded by default, but I haven't confirmed it. I don't know, for example, if it has to have the MPM worker specifically enabled. Unless you know the answer, I'll check on it (or it will become evident as soon as you try to do something in the build that requires it). This will be deferred to a follow-up, depending on whether it turns out to actually be an issue.

[TravisCarden]

@phenaproxima this is done except for one thing that I don't know whether it's on the application side or the CI config side:

PDOException: SQLSTATE[HY000]: General error: 8 attempt to write a readonly database

I've identified the database file created by creating the project (/var/www/web/db.sqlite) and set it to mode 0777 without any effect. What are your thoughts?

[TravisCarden]

@phenaproxima I rebased onto main. New problem:

$ composer create-project, etc...

...

Error: Hash mismatch for patch downloaded from https://git.drupalcode.org/project/distributions_recipes/-/raw/patch/recipe-10.3.x.patch
4f134408e250a2dfce06657a8e4f1b642c1081b1d4c66ce051dd8238e102036c; expected 88d4e6e1d0006d143ee6c8e16e143b39f3b70f61dd4985c32aa0423b2473d066

I can reproduce it locally, so it seems like it's an actual issue in the application.

[phenaproxima]

Yeah...we get that when the upstream patch changes but our patches.lock.json doesn't adjust. See what happens if you remove and gitignore patches.lock.json...?

[TravisCarden]

That doesn't seem to make any difference, @phenaproxima.

[TravisCarden]

The patches.lock.json problems went away after I rebased onto main. Running composer patches-relock causes a new and different problem, so I'm going to ignore it for now.

[TravisCarden]

@phenaproxima I'm still getting the same error trying to load the site after it's installed:

The website encountered an unexpected error. Try again later.
PDOException: SQLSTATE[HY000]: General error: 8 attempt to write a readonly database in Drupal\Component\DependencyInjection\PhpArrayContainer->createService() (line 77 of /var/www/web/core/lib/Drupal/Component/DependencyInjection/PhpArrayContainer.php).

Unfortunately, I'm having an unrelated problem with the build on this PR, but you can see the problem on the wip branch: https://github.com/phenaproxima/drupal-suite/actions/runs/8794640443/job/24134418742

Any ideas while I work on the PR build problem?

[phenaproxima]

So about that SQLite error -- a quick search reveals https://stackoverflow.com/questions/3319112/sqlite-error-attempt-to-write-a-readonly-database-during-insert:

The problem, as it turns out, is that the PDO SQLite driver requires that if you are going to do a write operation (INSERT,UPDATE,DELETE,DROP, etc), then the folder the database resides in must have write permissions, as well as the actual database file.

[phenaproxima]

I've created a way around this, I think. (It's in main now, so you'll need to rebase again.)

First, let's use MySQL on CI, instead of SQLite, since it seems to be problem-prone. Pretty sure you can easily do that with GitHub Actions' Docker integration.

What you'll need to do (pseudocode):

composer create-project --no-install ....
cd project
./vendor/bin/yaml-cli update:value ./drush/drush.yml command.site.install.options.db-url "mysql://user:password@server/dbname"
composer install
composer drupal:install

(This way, you can also remove the test -n "$CI" stuff from post-create-project-cmd, which will make it more portable.)

Drush requires grasmash/yaml-cli, but if it'll make you feel better, go ahead and add it as a direct dev dependency.

To me, this is absolutely good enough.

[TravisCarden]

@phenaproxima we have a working PR now. It doesn't do everything the way we (you) want, but it's fully functional, and it catches the main issues we tend to encounter. I propose you merge it as-is so we start getting the benefit, and we can iterate on it as we choose.

[phenaproxima]

Yeah, I agree. Let's just merge it and sally forth bravely!

[phenaproxima]

Welp, it's failing: https://github.com/phenaproxima/drupal-suite/actions/runs/8851596378. Can you fix? 🙏