Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record original image in annotation #45

Open
phenixblue opened this issue Jul 29, 2021 · 2 comments
Open

Record original image in annotation #45

phenixblue opened this issue Jul 29, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python

Comments

@phenixblue
Copy link
Owner

What would you like to be added:

The ImageSwap webhook should record the original image reference within an annotation if a swap occurs.

Why is this needed:

This will give a historic record of image swaps per resource for troubleshooting purposes.

This will need to account for multiple containers/init-containers within a pod

Maybe a json based list within an annotation value.

Example:

annotations:
  imageswap-webhook-swaps: ["image1", "image2", "image3"]
@phenixblue phenixblue added enhancement New feature or request python labels Jul 29, 2021
@ilrudie
Copy link
Collaborator

ilrudie commented Aug 1, 2021

Would it make sense to record the full detail of the swap?

annotations:
  imageswap-webhook-swaps: [{"original": "image1", "swap": "my.example.com/mirror-docker.io/image1"}, {"original": "quay.io/image2", "swap": "my.example.com/mirror-quay.io/image2"}]

@phenixblue
Copy link
Owner Author

I was originally thinking of just recording the original image since the current resource should show what the image was swapped to, but it's simple enough, we should be able to do both.

@phenixblue phenixblue added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python
Projects
None yet
Development

No branches or pull requests

2 participants