Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable to set listening port #83

Open
M4C4R opened this issue Sep 21, 2022 · 3 comments
Open

Environment variable to set listening port #83

M4C4R opened this issue Sep 21, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python

Comments

@M4C4R
Copy link
Contributor

M4C4R commented Sep 21, 2022

What would you like to be added:

I'd like to be able to set which port the application listens on, instead of being fixed to 5000.

Why is this needed:

It would add flexibility in allowing me to re-use already open ports as opposed to having to open a new one.

@M4C4R M4C4R added the enhancement New feature or request label Sep 21, 2022
@phenixblue phenixblue added help wanted Extra attention is needed good first issue Good for newcomers python labels Sep 23, 2022
@phenixblue
Copy link
Owner

Changing the port would require more than an ENV var. It would require changing the service as well. Can you provide more information on the scenario you have in mind? If I have more context, I may be able to better understand your needs and come up with another solution.

@M4C4R
Copy link
Contributor Author

M4C4R commented Jan 10, 2023

Hey @phenixblue, so this came out of #82, where I had to allow inbound access on the port the pod was listening on (5000) to get the webhook to work in AWS EKS.

As such, I'd like to be able to configure which port the application listens on (and the targetPort on the svc) to re-use already open ports.

@phenixblue
Copy link
Owner

Maybe I'm not familiar with something EKS is doing. Does it not target the port on the ImageSwap Service? The way I understand things is the Webhook Configuration should point at the Service/Port and not the pod/port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python
Projects
None yet
Development

No branches or pull requests

2 participants