Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Unknown' to Enumerations #49

Open
gordondavies opened this issue Apr 22, 2020 · 0 comments
Open

Add 'Unknown' to Enumerations #49

gordondavies opened this issue Apr 22, 2020 · 0 comments
Labels
enhancement New feature or request Half day

Comments

@gordondavies
Copy link

gordondavies commented Apr 22, 2020

https://npyc-toolbox.readthedocs.io/en/latest/enumerations.html

Some enumerations do not have some default values when the expected enum option is unknown.

ie, when importing sample metadata - if the 'Sample Type' is blank or not in the expected list (StudySample,StudyPool,ExternalReference,MethodReference,ProceduralBlank), it may be set incorrectly to StudySample - potentially making any downstream analysis imprecise or inaccurate.

Please add another Enum choice:

Unknown = 'Unknown' to all Enums with String Type values

Unknown = 0 to all Enums with Integer Type values

Please make sure in the toolbox code that whenever a blank or NA or null value is encountered, the correct Unknown is assigned.

@gordondavies gordondavies added the enhancement New feature or request label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Half day
Projects
None yet
Development

No branches or pull requests

2 participants