phet.joist.sim.version is "joist internal"

[pixelzoom]

ArithmeticModel contains this bit of code:

if ( ArithmeticQueryParameters.autoAnswer && window.phet.joist.sim.version.indexOf( '-' ) > 0 ) {
  this.autoAnswer();
}

window.phet.joist.sim.version is annotated as @public (joist-internal), so Arithmetic should not be using it. And it's causing me problems over in phetsims/joist#406, where I am investigating making sim.version go away.

[pixelzoom]

Looks like the above code is basically doing what we're trying to accomplish in phetsims/joist#406 -- that is, provide a way to decide whether to show answers. So once phetsims/joist#406 is addressed, it can be used here.

[pixelzoom]

If the identified code is intended to enable answers for dev & rc versions, it is incorrect. Published phetio versions also contain a '-', e.g. 1.0.0-phetio.

This points out another problem. Sims should not be parsing the version identifier. The version identifier should be read by something like SimVersion which handles the parsing, and provides clients with an API for accessing the version identifier. See phetsims/joist#411.

[pixelzoom]

3/9/17 developer meeting:
When phetsims/joist#411 is completed, use the API provided to address this issue.

[marlitas]

It does not look like phetsims/joist#411 is complete, and PhET-iO will not be part of the upcoming region and culture publication. Marking as deferred.