Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document version id conventions #636

Closed
pixelzoom opened this issue Dec 7, 2017 · 7 comments
Closed

document version id conventions #636

pixelzoom opened this issue Dec 7, 2017 · 7 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

From #560 (comment):

• TODO: Document this somewhere when it becomes reality.

Need to document version id, file/dir naming conventions, etc. after #560 has been closed.

@jonathanolson
Copy link
Contributor

Somewhat pending on phetsims/perennial#69, but the current version parsing uses major.minor.maintenance[-test][-oneOff] where test is testType.testNumber (e.g. dev.1). Major/minor/maintenance/testNumber are 1+ digits, and testType/oneOff is anything without "-" or ".".

toString is basically:

var str = `${this.major}.${this.minor}.${this.maintenance}`;
if ( typeof this.testType === 'string' ) {
  str += `-${this.testType}.${this.testNumber}`;
}
if ( typeof this.oneOff === 'string' ) {
  str += `-${this.oneOff}`;
}

I'll be free to fully document conventions when it is fully solidified.

@ariel-phet
Copy link
Contributor

labeling for dev meeting for a check in.

@pixelzoom
Copy link
Contributor Author

1/18/18 dev meeting: @jonathanolson will handle doc.

jonathanolson added a commit to phetsims/perennial that referenced this issue Jan 23, 2018
@jonathanolson
Copy link
Contributor

Documented in perennial's SimVersion. Is that location fine for the canonical documentation for how versioning works, or should that be moved to some .md file?

@jonathanolson
Copy link
Contributor

@pixelzoom, can you comment on whether there should be any improvements to the documentation?

@pixelzoom
Copy link
Contributor Author

Doc in SimVersion and #560 (comment) looks great.

Back to @jonathanolson in case there's anything else to do here. Feel free to close.

@pixelzoom pixelzoom assigned jonathanolson and unassigned pixelzoom Jan 23, 2018
@jonathanolson
Copy link
Contributor

Closing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants