Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots for all three sims #422

Open
zepumph opened this issue Oct 8, 2024 · 7 comments
Open

Screenshots for all three sims #422

zepumph opened this issue Oct 8, 2024 · 7 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Oct 8, 2024

While starting to publish to production, @samreid and I saw that screenshots need creating. @KatieWoe does QA normally do this step? I'm happy to help just point me in the right direction.

@KatieWoe
Copy link

KatieWoe commented Oct 8, 2024

Either QA or the designers usually do it. @DianaTavares do you have any preferences?

@zepumph
Copy link
Member Author

zepumph commented Oct 8, 2024

Looks like @arouinfar volunteered in slack.

@zepumph zepumph assigned arouinfar and unassigned DianaTavares and KatieWoe Oct 8, 2024
@KatieWoe
Copy link

KatieWoe commented Oct 8, 2024

Sounds good. I'm willing to help if needed @arouinfar

@arouinfar
Copy link

@zepumph @samreid I created screenshots for Buoyancy and Buoyancy: Basics and added them to main and 1.2 in the commits above. The website has a limit of 4 screenshots per sim, so I decided to leave out the Compare screen of Buoyancy.

@DianaTavares if you want to make any changes to the screenshots, we can do that later. This issue was blocking the publication of the suite, so I decided to go ahead and commit something.

@KatieWoe for the sake of time, I did not take the screen-specific screenshots because they are not yet being used anywhere. Can you please take care of those for Buoyancy and Buoyancy: Basics? A quick overview in case you're rusty:

  1. Set your viewport sizer to 1536x1008 px
  2. Run the sim with screens and recreate the situations in the screenshots I just committed, with the exceptions noted in (3) and (4) below.
  3. For Buoyancy: Basics, refer to the main screenshot and alt2.
  4. For Buoyancy -- Compare, create any scenario you'd like
  5. Follow the sim-name-screenshot-screenX.png naming convention, where X is the screen number.

@arouinfar arouinfar assigned DianaTavares and KatieWoe and unassigned arouinfar Oct 8, 2024
@arouinfar
Copy link

We decided not to retake the Density screenshots because there haven't been any significant visual changes to the sim since the 1.1 release.

@Nancy-Salpepi Nancy-Salpepi self-assigned this Oct 9, 2024
@Nancy-Salpepi Nancy-Salpepi removed their assignment Oct 9, 2024
KatieWoe added a commit to phetsims/buoyancy that referenced this issue Oct 9, 2024
KatieWoe added a commit to phetsims/buoyancy that referenced this issue Oct 9, 2024
KatieWoe added a commit to phetsims/buoyancy-basics that referenced this issue Oct 9, 2024
KatieWoe added a commit to phetsims/buoyancy-basics that referenced this issue Oct 9, 2024
@KatieWoe
Copy link

KatieWoe commented Oct 9, 2024

Commits above. Thanks @Nancy-Salpepi for taking the screenshots. @arouinfar everything look good?

@KatieWoe KatieWoe assigned arouinfar and unassigned KatieWoe Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants