Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sliders have grab/release sounds with keyboard nav #173

Closed
Nancy-Salpepi opened this issue Jun 1, 2024 · 3 comments
Closed

Some sliders have grab/release sounds with keyboard nav #173

Nancy-Salpepi opened this issue Jun 1, 2024 · 3 comments
Assignees

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jun 1, 2024

Test device
MacBook Air M1 chip

Operating System
14.5

Browser
Safari 17.5

Problem description
For phetsims/qa#1091
On the Electromagnet and Transformer screens, adjusting the sliders for the AC Power/Battery Voltage result in continuous grab and release sounds. This only happens with sliders on moveable objects and only with keyboard nav.

Steps to reproduce

  1. On the Electromagnet screen, tab to the slider on the DC Power Supply Panel
  2. Continually press the left arrow to move the slider

Visuals

grab.release.sounds.mov
@jessegreenberg
Copy link
Contributor

This was brought to my attention in phetsims/scenery#1636 and it should be fixed. @Nancy-Salpepi can you please confirm?

@Nancy-Salpepi
Copy link
Author

Sounds fixed in main. Should I go ahead and close this issue then @jessegreenberg?

@jessegreenberg
Copy link
Contributor

Great, thanks for verifying (and finding) @Nancy-Salpepi. I will close since this was a scenery issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants