-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layering saved line under/over green lines #121
Comments
This seems similar to #89, but involves a saved line and a "standard" line (y=x, y=-x). |
@pixelzoom thanks for finding that issue- I was looking for it! If we can prioritize the active/black line, then green line, then gray/saved line, I think that makes the most sense. |
The problem was that the model and view were using different orders for the lines. Fixed in the above commits. The order in model and view is now: interactive line, standard lines, saved lines. @KatieWoe please test in master. Here's a quick test procedure that covers all of the cases:
|
Looks good on master |
Pending regression testing in 1.3.0-rc.2. |
Looks good on both rcs. |
For phetsims/qa#277 and phetsims/qa#278
The green line appears to layer over the saved lines, but the pointer tool sticks to the saved lines over the green lines when they overlap. Not sure which is intended to be out front.
The text was updated successfully, but these errors were encountered: