Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layering saved line under/over green lines #121

Closed
KatieWoe opened this issue Feb 11, 2019 · 6 comments
Closed

Layering saved line under/over green lines #121

KatieWoe opened this issue Feb 11, 2019 · 6 comments
Labels

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#277 and phetsims/qa#278
The green line appears to layer over the saved lines, but the pointer tool sticks to the saved lines over the green lines when they overlap. Not sure which is intended to be out front.
layersone
layerstwo

@pixelzoom
Copy link
Contributor

This seems similar to #89, but involves a saved line and a "standard" line (y=x, y=-x).

pixelzoom added a commit that referenced this issue Feb 11, 2019
pixelzoom added a commit that referenced this issue Feb 11, 2019
pixelzoom added a commit that referenced this issue Feb 11, 2019
@amanda-phet
Copy link
Contributor

@pixelzoom thanks for finding that issue- I was looking for it! If we can prioritize the active/black line, then green line, then gray/saved line, I think that makes the most sense.

pixelzoom added a commit that referenced this issue Feb 11, 2019
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 11, 2019

The problem was that the model and view were using different orders for the lines. Fixed in the above commits. The order in model and view is now: interactive line, standard lines, saved lines.

@KatieWoe please test in master. Here's a quick test procedure that covers all of the cases:

  1. Start Graphing Lines.
  2. Go to Slope-Intercept screen.
  3. Change interactive equation to y = 4/4 + 0
  4. Press "Save line"
  5. Check the "y=x" check box.
  6. Put a point tool at (2,2). It's display should be black (interactive line)
  7. Change interactive equation to y = 5/4 + 0. The point tool's display should change to green (y=x).
  8. Uncheck the "y=x" check box. The point tool's display should change to gray (saved line).

@KatieWoe
Copy link
Contributor Author

Looks good on master

@KatieWoe KatieWoe assigned pixelzoom and unassigned KatieWoe Feb 11, 2019
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 11, 2019

Pending regression testing in 1.3.0-rc.2.

@KatieWoe
Copy link
Contributor Author

Looks good on both rcs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants