-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slope indicators go off the screen when in the game screen #122
Comments
In order to keep the slope indicator inside the layoutBounds (and on the graph), I'd need to invert it. And in the 2 examples above, that would look like -4,-2 and -10,-10 respectively, which are not the rise and run values that the user has entered. So whether we view this as a "teachable moment" or a limitation of the sim, I don't think it's something we should change. @amanda-phet do you agree? |
Wow! That is super easy to reproduce. What can we possibly do here? I will think about it. |
@pixelzoom you think we should not change it? Or did I misread what you said? I like your suggestion to invert it, since that is what we would probably do with pencil and paper. But since it's been around for a while I wonder if was actually a known issue and we decided to leave it. It does have a familiar ring to it. I think it would be good to check with @ariel-phet since he has a better understanding of timelines than I do, and he was also the original designer of the GL sim. |
We generally don't like to have things go off screen. But in this case, I'm wondering why we'd want to change anything. The current behavior accurately depicts the slope that the user has entered, and shows them that what they entered is "off screen" in perhaps the clearest way possible. |
@amanda-phet asked:
I didn't suggest inverting, I pointed out the problems with inverting. So no, I don't think we should change anything, see #122 (comment). |
@pixelzoom I think we should mark this as "won't fix" The sim has been used extensively already in Java and HTML5, and we have not received any comments of this nature. Is it ideal to have things go off screen....not really, but I am not sure there is any particularly great solution that is worth the extra cost/complexity at this point. |
OK, closing this as "won't fix". @KatieWoe thank you again for reporting. |
For phetsims/qa#277 and phetsims/qa#278. This does occur in the published version.
It is possible to make the blue slope markers go off the screen when in the game screen.
To do this, find a level where you make a line with the spinners and ideally can control both height and slope. This can be done without control of both as long as the one not being controlled starts with a correct value for the bug. Make sure the y-value of the point is as high as you can make it, then increase the y-value of the slope. the slope need to be positive.
The text was updated successfully, but these errors were encountered: