Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert joist string usage to dynamic strings #873

Closed
jonathanolson opened this issue Oct 20, 2022 · 5 comments
Closed

Convert joist string usage to dynamic strings #873

jonathanolson opened this issue Oct 20, 2022 · 5 comments
Assignees
@AgustinVallejo
Labels
status:ready-for-review

Comments

@jonathanolson
Copy link
Contributor

No description provided.

@zepumph
Copy link
Member

zepumph commented Oct 26, 2022

I will work with Agustin on that issue.

@zepumph zepumph mentioned this issue Oct 28, 2022
Open
AgustinVallejo added a commit that referenced this issue Oct 28, 2022
@AgustinVallejo
Making strings in Joist support dynamic locales, see #873
87af221
@zepumph
Copy link
Member

zepumph commented Nov 22, 2022

Could I please review this to double check?

@zepumph zepumph reopened this Nov 22, 2022
@zepumph zepumph self-assigned this Nov 22, 2022
@zepumph zepumph mentioned this issue Nov 25, 2022
Closed
@zepumph
Copy link
Member

zepumph commented Nov 25, 2022

  • still some todos I'll take a look at

@zepumph zepumph mentioned this issue Nov 25, 2022
Open
zepumph added a commit that referenced this issue Nov 25, 2022
@zepumph
update todo, #885 #873
0da9dd9
zepumph added a commit that referenced this issue Nov 25, 2022
@zepumph
convert to PatternStringProperty from StringUtils.fillIn, #873
cd1088d
@zepumph
Copy link
Member

zepumph commented Nov 25, 2022

Review:

@zepumph zepumph assigned AgustinVallejo and unassigned zepumph Nov 25, 2022
@phet-dev phet-dev reopened this May 4, 2023
@phet-dev
Copy link
Contributor

phet-dev commented May 4, 2023

Reopening because there is a TODO marked for this issue.

@zepumph zepumph closed this as completed in cf36196 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathanolson @zepumph @phet-dev @AgustinVallejo