Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it OK to have irrelevant info in the keyboard dialog after PhET-iO customizations? #936

Open
Nancy-Salpepi opened this issue Aug 28, 2023 · 2 comments

Comments

@Nancy-Salpepi
Copy link

When testing phetsims/qa#973, I noticed that removing the Play/Pause button or the Reset All button in studio also disables the corresponding keyboard shortcut (alt/opt + K and alt/opt + R). However, those shortcuts will still be listed in the dialog. Is it OK to still have that information there even though it is no longer relevant?

@arouinfar
Copy link

Thanks for opening this @Nancy-Salpepi. I've added this to the PhET-iO Meeting agenda to make sure we're on the same page.

@jbphet this does not block Greenhouse Effect.

@pixelzoom
Copy link
Contributor

Trying to automatically show/hide parts of the keyboard help based on which parts of the UI are visible is not a problem that I think we should try to solve. It will introduce big complications for little-to-no benefit. It would be better to instrument visibleProperty for sections of keyboard help, and allow the instructional designer to hide irrelevant sections – if that’s important to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants