Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify sims that have Safari 17.4 quadratic rendering problem #1069

Closed
27 of 30 tasks
pixelzoom opened this issue Apr 9, 2024 · 5 comments
Closed
27 of 30 tasks

Identify sims that have Safari 17.4 quadratic rendering problem #1069

pixelzoom opened this issue Apr 9, 2024 · 5 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 9, 2024

In phetsims/graphing-quadratics#206, @Nancy-Salpepi discovered a bug in Safari 17.4 on Apple chips. That bug was related to using SVG to draw quadratic curves, and was resolved for graphing-quadratics.

The bug is being tracked more generally in phetsims/scenery#1628.

In phetsims/graphing-quadratics#206 (comment), @kathy-phet said:

@Nancy-Salpepi @KatieWoe - Sounds like you should keep an eye out for additional related issues to this on other sims.

According to @jonathanolson, sims that use these methods of kite.Shape are liable to have this problem:

  • quadraticCurveTo
  • quadraticCurveToPoint (the method that was failing in graphing-quadratics)
  • quadraticCurveToRelative
  • quadraticCurveToPointRelative
  • smoothQuadraticCurveTo
  • smoothQuadraticCurveToRelative

Sims that call one or more of those methods directly include:

  • area-builder
  • balloons-and-static-electricity
  • build-an-atom
  • energy-skate-park
  • faradays-electromagnetic-lab (for drawing the coils)
  • faradays-law
  • fluid-pressure-and-flow
  • fraction-comparison
  • gene-expression
  • geometric-optics (for drawing the lens and mirror shapes)
  • hookes-law (for the Energy plot)
  • neuron
  • projectile-data-lab
  • projectile-motion
  • proportion-playground
  • states-of-matter

One or more of those methods are also used in these scenery-phet UI components:

BicyclePumpNode (used to draw the pump handle and front edge)

  • gas-properties
  • states-of-matter

ProbeNode

  • beers-law-lab
  • bending-light
  • circuit-construction-kit-common (the CCK suite)
  • energy-skate-park
  • ph-scale
  • wave-interference

ReturnButton / ReturnIcon

  • build-a-nucleus
  • calculus-grapher
  • expression-exchange
  • forces-and-motion-basics
  • fractions-common (the fractions suite)
  • number-suite-common (the numbers suite)
@pixelzoom
Copy link
Contributor Author

@KatieWoe You'll probably want to check with @kathy-phet to confirm that this is a project worth doing, or whether to wait until problems are reported.

This is obviously a huge amount of stuff to test. And without assistance from the sim developer, it's not at all clear what should even be tested. For the sims that I'm familar with, I've provided details above.

It's also possible that @jonathanolson might be able to prune this task down a bit. Also worth following up on where @jonathanolson is with reporting this problem to the WebKit team for phetsims/scenery#1628, and whether a fix for Safari 17.4 is forthcoming.

@KatieWoe
Copy link
Contributor

QA is done

@KatieWoe KatieWoe assigned pixelzoom and unassigned KatieWoe Jun 11, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 11, 2024

This is obviously a huge amount of stuff to test. And without assistance from the sim developer, it's not at all clear what should even be tested.

@KatieWoe Can you please summarize what was tested, and what the results were?

Also worth following up on where @jonathanolson is with reporting this problem to the WebKit team for phetsims/scenery#1628, and whether a fix for Safari 17.4 is forthcoming.

And did someone follow up on this?

@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom Jun 11, 2024
@KatieWoe
Copy link
Contributor

Sorry, I missed this earlier. We looked through the sims in the Safari browser and focused in particular on graphs, changing lines, the items described such as probes, and looked for graphical issues and disappearing elements. I don't believe we encountered similar issues, or they would have been recorded.

@pixelzoom
Copy link
Contributor Author

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants