Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Reactants, Products and Leftovers 1.2.0-rc.2 #169

Closed
3 tasks done
pixelzoom opened this issue Aug 13, 2018 · 4 comments
Closed
3 tasks done

RC test: Reactants, Products and Leftovers 1.2.0-rc.2 #169

pixelzoom opened this issue Aug 13, 2018 · 4 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 13, 2018

Previous RC test was #162.

@KatieWoe, Reactants, Products and Leftovers 1.2.0-rc.2 is ready for RC testing.

Link to sim _en.html
Link to sim _all.html
Link to sim iframe
Link to sim XHTML

This RC test does not require a test matrix. You can spot check the issues listed below.

Issues to Verify
Please test the following issues and check them off after addressing. If they are resolved, close them. If not, they should be updated.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 13, 2018

Note to self... Steps used to create this RC:

cd perennial
grunt checkout-target --repo=reactants-products-and-leftovers --branch=1.2

# Cherry pick sim fixes
cd reactants-products-and-leftovers
git checkout master -- js/game/view/ResultsNode.js
git add js/game/view/ResultsNode.js
git commit -m '#60'
git push

# Branch vegas and cherry pick fixes
cd vegas
git checkout -b reactants-products-and-leftovers-1.2
git checkout master -- js/FiniteStatusBar.js
git add js/FiniteStatusBar.js
git commit -m 'phetsims/reactants-products-and-leftovers#59'
git push
git checkout master -- js/LevelSelectionButton.js
git add js/LevelSelectionButton.js
git commit -m 'phetsims/reactants-products-and-leftovers#61'
git push

# Update dependencies.json
cd reactants-products-and-leftovers
grunt
cp build/phet/dependencies.json .
git add dependencies.json
git commit -m 'use vegas branch reactants-products-and-leftovers-1.2'
git push

# Deploy the RC
grunt rc --brands=phet --branch=1.2

@KatieWoe
Copy link
Contributor

QA is done

@pixelzoom
Copy link
Contributor Author

Thanks @KatieWoe! I'll proceed with publishing 1.2.0.

@pixelzoom
Copy link
Contributor Author

1.2.0 has been published. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants