Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable showAnswers in production versions #51

Closed
pixelzoom opened this issue Feb 26, 2017 · 3 comments
Closed

disable showAnswers in production versions #51

pixelzoom opened this issue Feb 26, 2017 · 3 comments
Labels
status:fixed-awaiting-deploy

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 26, 2017 •
edited
Loading

phetsims/joist#406 is a prerequisite to this.

In RPALQueryParameters, set showAnswers to false if we're running a production version, so the answers can't be revealed.
@pixelzoom pixelzoom self-assigned this Feb 26, 2017
@pixelzoom pixelzoom changed the title disable query parameters the reveal answers in production versions disable query parameters that reveal answers in production versions Feb 28, 2017
@pixelzoom pixelzoom removed their assignment Mar 7, 2017
pixelzoom added a commit that referenced this issue Apr 4, 2017
@pixelzoom
standardize on showAnswers query parameter, #51
f637ae9
@pixelzoom pixelzoom changed the title disable query parameters that reveal answers in production versions disable showAnswers in production versions Apr 4, 2017
@pixelzoom
Copy link
Contributor Author

Deferred until we have a way to identify production versions, see phetsims/joist#406.

pixelzoom added a commit that referenced this issue Jul 13, 2018
@pixelzoom
disable showAnswers, #51
3351a21 
Signed-off-by: Chris Malley <[email protected]>
@pixelzoom
Copy link
Contributor Author

Done in master, awaiting deployment.

@jonathanolson jonathanolson mentioned this issue Aug 6, 2018
Closed
11 tasks
@pixelzoom
Copy link
Contributor Author

Verified in RC test phetsims/qa#162, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-awaiting-deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom