Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RulerNode should handle dynamic layout #817

Open
marlitas opened this issue Aug 18, 2023 · 0 comments
Open

RulerNode should handle dynamic layout #817

marlitas opened this issue Aug 18, 2023 · 0 comments
Assignees

Comments

@marlitas
Copy link
Contributor

While working on the Sound Waves prototype (phetsims/sound-waves#23) we discovered that the unit label runs off the end of the ruler with stringTest=dynamic.

image

While looking through the code for RulerNode we determined that a fix for this was not within the scope of the Sound Waves prototype, however it should be addressed when Sound Waves is picked up again for redesign. It may be worth going through other sims that use the RulerNode to double check if they have this same problem as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants