Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setGroupFocusHighlight #1608

Open
jessegreenberg opened this issue Feb 8, 2024 · 1 comment
Open

Improve setGroupFocusHighlight #1608

jessegreenberg opened this issue Feb 8, 2024 · 1 comment

Comments

@jessegreenberg
Copy link
Contributor

From an old TODO in the code.

  1. We want to expand the groupFocusHighlight so that it can support the same types as focusHighlight.
  2. Consider supporting more than one group focus highlight at a time (multiple targets in the Trail)

But not a high priority for now.

@jessegreenberg
Copy link
Contributor Author

Consider supporting more than one group focus highlight at a time (multiple targets in the Trail)

I do not think we should support this.
screenshot_3184_360

In this example, a groupFocusHighlight: true is on the ComboBoxListBox and also the entire panel. The group highlight on the panel shows that it is interactive while subcomponents have focus. But when the ComboBox is open, the panel is not interactive. And in my opinion having several group focus highlights displayed would be more confusing and even poor accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants