Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace decorator pattern used in DoubleNumberLineAccordionBox #227

Closed
jessegreenberg opened this issue Aug 20, 2024 · 1 comment
Closed

Comments

@jessegreenberg
Copy link
Contributor

From phetsims/sun#860, components with "content" cannot be decorated with other Nodes and this case was found.

// Adjust rectangle to match accordion box size.
thisBoundsNode.setRectBounds( this.localBounds );
this.addChild( thisBoundsNode );
thisBoundsNode.moveToBack();

A potential way to replace this is in the following commit, @pixelzoom can you please review and change if there is a better way for this sim?

@pixelzoom
Copy link
Contributor

Thanks @jessegreenberg, that's a nice improvement. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants