Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changes from @mfiano #12

Open
phoe opened this issue May 22, 2021 · 1 comment
Open

Implement changes from @mfiano #12

phoe opened this issue May 22, 2021 · 1 comment

Comments

@phoe
Copy link
Owner

phoe commented May 22, 2021

https://gist.github.com/mfiano/3ddf2810cf8101f66009c3fdde8b020b

  • The local swap functions are closing over state. Make them take the parent and left/right indices. To do this just return the left/right indices and wrap the callers in (setf parent-index ...).
  • You can lexibind some aref lookups that are called multiple times, particular the parent, left, and right priority.
  • In some various other places in the codebase, you can also lexibind the aref calls that are called more than once. I forget where though.

Also read-eval (ash 1 64) just to be sure it's a constant for implementations that don't do constant folding for whatever reason.

@phoe
Copy link
Owner Author

phoe commented Jan 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant