Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect date in Gallery #872

Open
patricksan opened this issue Aug 13, 2012 · 16 comments
Open

Incorrect date in Gallery #872

patricksan opened this issue Aug 13, 2012 · 16 comments

Comments

@patricksan
Copy link
Member

I added photos from the same date (August 11th.) and in some point it says 12th.

Screen

@hfiguiere
Copy link
Member

I'm wondering if this isn't a timezone issue.

@jmathai
Copy link
Member

jmathai commented Aug 13, 2012

@hfiguiere My guess is that it is.

@patricksan
Copy link
Member Author

@hfiguiere @jmathai

Metadata has the correct data:
https://dl.dropbox.com/u/138224/Github/metadata_IMG_2618.txt
https://dl.dropbox.com/u/138224/Github/metadata_IMG_2797.txt

When in the view details, both photos has "2 days ago"

First image:
First image

Second image:
second image

@jmathai
Copy link
Member

jmathai commented Aug 13, 2012

Hmmm....the reason might be because on the gallery view it is the JavaScript Date object we're using and it uses the client's time.

@hfiguiere
Copy link
Member

shouldn't we use PHP for that instead.

@jmathai
Copy link
Member

jmathai commented Aug 15, 2012

@hfiguiere I'm not 100% that's the culprit but the rendering of the list view in the beisel 2.0 theme is done via JavaScript. The unix timestamp passed back by the API is sent into JS' Date object. I need to confirm if that's the cause or if it's a general timezone issue that exists in PHP land as well.

@patricksan
Copy link
Member Author

@bpavot
Copy link

bpavot commented Jun 16, 2013

Yes, it is a client timezone issue :
See bugfix #1318

@hfiguiere
Copy link
Member

Like bug #1286 I believe it is the same thing.

@hfiguiere
Copy link
Member

BTW top picture link is gone. Only two years...

@jmathai
Copy link
Member

jmathai commented Aug 18, 2014

BTW top picture link is gone. Only two years...

That was uploaded to Github, no? How could they be gone??

@hfiguiere
Copy link
Member

Not sure. The Github clown? Maybe one should ask Github.

@hfiguiere
Copy link
Member

BTW PR #1526 should have this fixed.

@hfiguiere
Copy link
Member

if not then I need the missing info and we'll fix it.

@jmathai
Copy link
Member

jmathai commented Aug 20, 2014

@hfiguiere I merged commit e4d905f. Can you confirm and mark as closed?

@hfiguiere
Copy link
Member

Can't confirm this specific problem is fixed since the screenshots are gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants