Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed constants in SPL extension #12358

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Typed constants in SPL extension #12358

merged 3 commits into from
Oct 7, 2023

Conversation

jorgsowa
Copy link
Contributor

@jorgsowa jorgsowa commented Oct 4, 2023

This PR adds typing to the class constants in SPL extension.

@jorgsowa jorgsowa requested a review from Girgias as a code owner October 4, 2023 19:27
@Girgias Girgias requested a review from kocsismate October 4, 2023 23:17
kocsismate
kocsismate reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd be curious about other reviewer's comments though

@Girgias
Copy link
Member

Girgias commented Oct 6, 2023

I'm also in favour, but this will require an entry in UPGRADING

@jorgsowa
Copy link
Contributor Author

jorgsowa commented Oct 6, 2023

@Girgias, added note to the UPGRADING file.

@Girgias Girgias merged commit f075710 into php:master Oct 7, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate left review comments

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: spl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgsowa @Girgias @kocsismate