Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve range array overflow error message #16510

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Conversation

divinity76
Copy link
Contributor

added info about "how much it exceeded" and the maximum allowable array size.

Makes debugging easier when encountering this specific issue.

added info about "how much it exceeded" and the maximum allowable array size.

Makes debugging easier when encountering this specific issue.
@divinity76 divinity76 requested a review from bukka as a code owner October 19, 2024 14:41
@divinity76 divinity76 marked this pull request as draft October 19, 2024 14:46
@divinity76 divinity76 marked this pull request as ready for review October 19, 2024 15:04
@divinity76
Copy link
Contributor Author

interestingly it works when building locally but fails on the CI's 🤔 (the 32bit I can understand, but it fails even on the 64bit builds)

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one NIT but LGTM

ext/standard/array.c Outdated Show resolved Hide resolved
@divinity76
Copy link
Contributor Author

managed to resolve the running-on-CI failures, somehow.

@bukka bukka merged commit 47e4400 into php:master Dec 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants