Report Windows Server 2025 in php_uname #16838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Nov 17, 2024
|
I think due to the requirement that GA = last RC, this might need to wait until .1. (edit: But it does seem the rule is not really binding per this thread, and this seems cosmetic, so if that's the case, I don't have a problem with merging this if other RMs are OK with it.) |
|
Thank you! Applied to PHP-8.4 and merged up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Server 2025 was released on 2024-11-01 with a major build number of 26100 (matching Windows 11 24H2). With this patch
php_unamewill return the correct version string (currentlyWindows Server 2022).Previous related PR for Windows Server 2022 and earlier: #7816
I'm targeting
masterbut please let me know if I should choosePHP-8.4or something else as the base branch.