Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed work with Shared Memory on Windows. #17273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CoderAImen
Copy link

Fixed work with Shared Memory on Windows.

@devnexen
Copy link
Member

Hi @CoderAImen. And thanks for your contribution, what is your patch fixing precisely ?

@CoderAImen
Copy link
Author

CoderAImen commented Dec 26, 2024

Hi @CoderAImen. And thanks for your contribution, what is your patch fixing precisely ?

Corrects errors on request
#17245 (comment)

@devnexen
Copy link
Member

Alright then, will leave it to the appropriate folk.

TSRM/tsrm_win32.c Outdated Show resolved Hide resolved
TSRM/tsrm_win32.c Outdated Show resolved Hide resolved
Corrections based on comments.
Copy link
Author

@CoderAImen CoderAImen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections based on comments have been made.

@CoderAImen CoderAImen requested a review from devnexen December 27, 2024 08:59
TSRM/tsrm_win32.c Outdated Show resolved Hide resolved
Syntax fixes
@CoderAImen CoderAImen requested a review from mvorisek December 27, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared memory descriptors are not closed after PHP program execution is complete.
3 participants