Move language_choose_code() into new LangChooser class
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can easily write test codes without calls of `myphpnet_language()` and `default_language()`.
|
🚀 Regression report for commit b585014 is at https://web-php-regression-report-pr-1081.preview.thephp.foundation |
|
🚀 Preview for commit b585014 can be found at https://web-php-pr-1081.preview.thephp.foundation |
saundefined
reviewed
Sep 24, 2024
saundefined
approved these changes
Oct 14, 2024
sy-records
approved these changes
Oct 14, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new class,
LangChooser, replacing thelanguage_choose_code()function.The goal is to make
/releases/8.3/index.phprespect users' language preferences, similar to the manual pages. I initially considered reusinglanguage_choose_code(), but its reliance on global variables made that challenging. As a result, I refactored the logic into a new class to simplify reuse in the/releasespages.A follow-up PR to update
/releases/8.3/index.phpwill be submitted once this PR is merged.