Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure image target node #917

Open
jaapio opened this issue Mar 9, 2024 · 0 comments
Open

Restructure image target node #917

jaapio opened this issue Mar 9, 2024 · 0 comments
Labels
Milestone

Comments

@jaapio
Copy link
Member

jaapio commented Mar 9, 2024

Feature request

In #914 the image target was added, but rather than adding a new node to the image as target it would make more sense to wrap the image node in a link node like a decoration on the image node.

To do this we need to change the hyperlink nodes to a compound version that will allow us to make a more complex node structure. We consider this a BC break as template authors need to update their templates. Therefor this has been scheduled for v2.0.0 of this library.

@jaapio jaapio added the feature label Mar 9, 2024
@jaapio jaapio added this to the 2.0.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant