Module dependency > update module case check

[Marc-pi]

@taiwen

In mymodule/config/module.php, we can set module dependency through an array

// Module dependency: list of module directory names, optional
    'dependency'    => array(
    ),

We checked the code :

• at first install, it displays a warning and ask to install the dependant module before (you cannot install instead)
• But seems some code was done to manage also Update, but seems it does not work
  • we were not able to reach the IF condition during a module upgrade
    if ($this->event->getParam('upgrade'))

Fichier Pi/Application/Installer/Action/Update.php :

protected function attachDefaultListeners()
   {
       $events = $this->events;      
       if ($this->event->getParam('upgrade')) {
           $events->attach('update.post', array($this, 'removeDependency'));
           $events->attach('update.post', array($this, 'createDependency'));
       }

       return $this;
   }

Is there something we missed to use this ?

Or is such this change the solution?

protected function attachDefaultListeners()
   {
       $events = $this->events;
       $events->attach('update.pre', array($this, 'checkIndependent'));
       
       if ($this->event->getParam('upgrade')) {
           $events->attach('update.post', array($this, 'removeDependency'));
           $events->attach('update.post', array($this, 'createDependency'));
       }

       return $this;
   }