diff --git a/README.md b/README.md index 2cd2b210..b1b6aa86 100644 --- a/README.md +++ b/README.md @@ -47,9 +47,7 @@ services: # Set the appropriate timezone for your location (https://en.wikipedia.org/wiki/List_of_tz_database_time_zones), e.g: TZ: 'Europe/London' # Set a password to access the web interface. Not setting one will result in a random password being assigned - FTLCONF_webserver_api_password: 'correct horse battery staple' - # Configure DNS upstream servers, e.g: - FTLCONF_dns_upstreams: '8.8.8.8;8.8.4.4' + FTLCONF_webserver_api_password: 'correct horse battery staple' # Volumes store your data between container upgrades volumes: # For persisting Pi-hole's databases and common configuration file diff --git a/examples/docker-compose-caddy-proxy.yml b/examples/docker-compose-caddy-proxy.yml index 49e6fdea..28e7d113 100644 --- a/examples/docker-compose-caddy-proxy.yml +++ b/examples/docker-compose-caddy-proxy.yml @@ -35,9 +35,7 @@ services: # Set the appropriate timezone for your location (https://en.wikipedia.org/wiki/List_of_tz_database_time_zones), e.g: TZ: 'Europe/London' # Set a password to access the web interface. Not setting one will result in a random password being assigned - FTLCONF_webserver_api_password: 'correct horse battery staple' - # Configure DNS upstream servers, e.g: - FTLCONF_dns_upstreams: '8.8.8.8;8.8.4.4' + FTLCONF_webserver_api_password: 'correct horse battery staple' # Volumes store your data between container upgrades volumes: # For persisting Pi-hole's databases and common configuration file diff --git a/src/bash_functions.sh b/src/bash_functions.sh index a455e1a2..cc4f1c8d 100644 --- a/src/bash_functions.sh +++ b/src/bash_functions.sh @@ -61,13 +61,10 @@ ensure_basic_configuration() { chown pihole:pihole /macvendor.db fi - # If getFTLConfigValue "dns.upstreams" returns [], exit the container. We need upstream servers to function! - if [[ $(getFTLConfigValue "dns.upstreams") == "[]" ]]; then - echo "" - echo " [X] No DNS upstream servers are set!" - echo " [i] Recommended: Set the upstream DNS servers in the environment variable FTLCONF_dns_upstreams" - echo "" - exit 1 + # If getFTLConfigValue "dns.upstreams" returns [], default to Google's DNS server + if [[ $(getFTLConfigValue "dns.upstreams") == "[]" ]]; then + echo " [i] No DNS upstream set in environment or config file, defaulting to Google DNS" + setFTLConfigValue "dns.upstreams" "[\"8.8.8.8\", \"8.8.4.4\"]" fi setup_web_password diff --git a/test/tests/test_general.py b/test/tests/test_general.py index 78f1604a..1da05792 100644 --- a/test/tests/test_general.py +++ b/test/tests/test_general.py @@ -14,14 +14,14 @@ def test_pihole_gid_env_var(docker): # Wait 5 seconds for startup, then kill the start.sh script -# Finally, tail the FTL log to see if it has been shut down cleanly +# Finally, grep the FTL log to see if it has been shut down cleanly def test_pihole_ftl_clean_shutdown(docker): func = docker.run( """ sleep 5 killall --signal 15 start.sh sleep 5 - tail -f /var/log/pihole-FTL.log + grep 'jmpret\|terminated' /var/log/pihole/FTL.log """ ) assert "INFO: Shutting down... // exit code 0 // jmpret 0" in func.stdout