Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Settings" -> "System" -> "Restart DNS resolver": Small formatting issue #3117

Closed
AS98765 opened this issue Aug 7, 2024 · 5 comments
Closed

Comments

@AS98765
Copy link

AS98765 commented Aug 7, 2024

Versions

  • Pi-hole: v5.18.3
  • AdminLTE: v5.25.2
  • FTL: v5.21

Platform

  • OS and version: Raspberry Pi OS Lite (64-bit), Bookworm
  • Platform: Raspberry Pi

Expected behavior

The same formatting scheme as the other 5 "System" settings.

Orange buttons to orange Yes buttons.
Red buttons to red Yes buttons.

Actual behavior / bug

Orange button to red Yes button does not correspond to the intended logic in my opinion :).

Steps to reproduce

Imo not necessary

Debug Token

...

Screenshots

Screenshot 2024-08-17 125455

Screenshot 2024-08-17 125915

Screenshot 2024-08-17 125937

Screenshot 2024-08-17 130051 - m

Screenshot 2024-08-17 130130

Screenshot 2024-08-17 130242

Screenshot 2024-08-17 130313

Additional context

N/A

@AS98765
Copy link
Author

AS98765 commented Aug 17, 2024

Screenshots added.

@yubiuser
Copy link
Member

Thanks for the report. The issue persist even on v6 for the resolver restart and flushing the network table.

@noelthekk
Copy link

Hey team, I am big fan of the project and looking to contribute. Can someone give me some context as to what the issue is. Is it the colour of the button ?

@rdwebdesign
Copy link
Member

This issue is relate to the difference between the color of the "Restart DNS resolver" button:
image

and the color of the confirmation button, inside the modal window:
image

The other buttons use the same color for both buttons, but this one is using different colors.


To be honest, I think the colors were initially select (a long long time ago) to differentiate between options considered very danger/irreversible (red) or not (yellow), but the original buttons were replaced a few times and the colors remained.

Currently the colors are not very tight related to the meaning of the buttons. Also, some buttons were already changed again in Pi-hole v6.

@yubiuser yubiuser transferred this issue from pi-hole/pi-hole Aug 26, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Sep 26, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants