ddl: table collation should follow schema #58482
Conversation
ti-chi-bot
bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/L
|
Hi @dveeden. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/check-issue-triage-complete |
|
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58482 +/- ##
================================================
+ Coverage 73.5201% 74.8788% +1.3586%
================================================
Files 1681 1726 +45
Lines 464346 472475 +8129
================================================
+ Hits 341388 353784 +12396
+ Misses 102131 96412 -5719
- Partials 20827 22279 +1452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/ddl/executor.go
Outdated
| objectChs := charsetOpts[0].Chs | ||
| objectColl := charsetOpts[0].Col | ||
| if len(charsetOpts) > 1 { | ||
| templChs = charsetOpts[1].Chs | ||
| templColl = charsetOpts[1].Col | ||
| } |
There was a problem hiding this comment.
in ProcessColumnCharsetAndCollation, there might be 3 items in the slice
There was a problem hiding this comment.
Ok, so that's column, table, schema.
I'll make sure to add tests for that, and either make ResolveCharsetCollation handle this or have ProcessColumnCharsetAndCollation use a slice of 2 items.
There was a problem hiding this comment.
I haven't found any situation yet in which the third item in ProcessColumnCharsetAndCollation is useful.
| if utf8mb4Coll != "" { | ||
| return chs, utf8mb4Coll, nil | ||
|
|
||
| if chs == "" || coll == "" { |
There was a problem hiding this comment.
it's odd to have such a branch without handling cases that any one of it is empty, we can move above handling to here
|
@dveeden: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dveeden: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #58446
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.