Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix version syncer doesn't print who hasn't synced on partial sync #58511

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ddl: fix version syncer doesn't print who hasn't synced on partial sync #58511

wants to merge 3 commits into from
+7 −7

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #58480

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

tiup playground; add sleep(5 seconds) on domain reload, and then start a tidb with this PR. run create table

before

[2024/12/24 18:28:04.889 +08:00] [INFO] [syncer.go:403] ["syncer check all versions, all nodes are not synced"] [category=ddl] ["ddl job id"=111] [ver=55]
[2024/12/24 18:28:05.891 +08:00] [INFO] [syncer.go:403] ["syncer check all versions, all nodes are not synced"] [category=ddl] ["ddl job id"=111] [ver=55]

after

[2024/12/24 18:45:50.058 +08:00] [INFO] [syncer.go:398] ["syncer check all versions, someone is not synced"] [category=ddl] [info="instance ip 192.168.206.89, port 5000, id 8d02f9b2-bfe1-4292-a1ef-5c1ef86eebf8"] ["ddl job id"=117] [ver=58]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 24, 2024
@tiprow tiprow
Copy link

tiprow bot commented Dec 24, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.9220%. Comparing base (457dcc6) to head (be92c7b).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58511        +/-   ##
================================================
+ Coverage   73.5697%   74.9220%   +1.3522%     
================================================
  Files          1681       1726        +45     
  Lines        464249     472343      +8094     
================================================
+ Hits         341547     353889     +12342     
+ Misses       101876      96170      -5706     
- Partials      20826      22284      +1458
Flag Coverage Δ
integration 49.0068% <0.0000%> (?)
unit 72.3275% <28.5714%> (-0.0097%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6985% <ø> (+15.9239%) ⬆️

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Dec 24, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-25 05:38:32.585190851 +0000 UTC m=+1626502.673993393: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when only some node hasn't sync, DDL owner always print 'syncer check all versions, all nodes are not synced'
2 participants
@D3Hunter @lance6716