Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make check for allLogs more explicit #362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: make check for allLogs more explicit #362

wants to merge 2 commits into from

Conversation

todor-a
Copy link

@todor-a todor-a commented Dec 9, 2024

Closes #361.

jsumners
jsumners reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a nit.

logger.js Outdated Show resolved Hide resolved
@todor-a @jsumners
make check explicit
b270ddd 
Co-authored-by: James Sumners <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue while testing - res.allLogs is not defined
2 participants
@todor-a @jsumners