Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling the LiveState feature #5270

Open
t-kikuc opened this issue Oct 8, 2024 · 4 comments
Open

Support disabling the LiveState feature #5270

t-kikuc opened this issue Oct 8, 2024 · 4 comments
Labels
kind/enhancement New feature or request

Comments

@t-kikuc
Copy link
Member

t-kikuc commented Oct 8, 2024

What would you like to be added:

  • Support disabling the LiveState feature for a platform-provider.

Why is this needed:

  • For those who don't need DriftDetection and LiveState UI, the LiveState feature is not necessary.
  • LiveState feature calls a lot of APIs (e.g. AWS, GCP, etc.), but it would lead to higher cost.
    • Especially, the number of API calls tends to be higher for function platforms like Lambda/CloudRun.
@t-kikuc t-kikuc added the kind/enhancement New feature or request label Oct 8, 2024
@t-kikuc
Copy link
Member Author

t-kikuc commented Oct 8, 2024

💡 An idea of implementation is like this: 8298808

@khanhtc1202
Copy link
Member

I think the configuration for features like livestate or drift detection to be on/off should belong to application configuration instead of piped platform provider or plugin config since users may use the same platform/plugin config of piped to manage various applications with different attentions, wdyt? 🤔

@t-kikuc
Copy link
Member Author

t-kikuc commented Oct 8, 2024

Disabling LiveState&DriftDetection for each app does not have an effect on reducing API calls.
Even if LiveState of only one app is enabled, livestatestore will fetch all resources.

@ffjlabo
Copy link
Member

ffjlabo commented Oct 16, 2024

FYI, it seems that there was a similar issue with disabling drift detection: #4508.
This is implemented as a temporary option for the terraform provider in the piped config.
https://pipecd.dev/docs-v0.49.x/user-guide/managing-piped/configuration-reference/#platformproviderterraformconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants