Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more options to control piped planpreview render behavior #5275

Open
khanhtc1202 opened this issue Oct 10, 2024 · 0 comments
Open

Enable more options to control piped planpreview render behavior #5275

khanhtc1202 opened this issue Oct 10, 2024 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@khanhtc1202
Copy link
Member

What would you like to be added:

We have a bunch of options to control the piped plan preview handler, but not all of them are in use now

		h := planpreview.NewHandler(
			gc,
			apiClient,
			commandLister,
			applicationLister,
			lastTriggeredCommitGetter,
			decrypter,
			appManifestsCache,
			cfg,
			planpreview.WithLogger(input.Logger),
		)

across piped.go (ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/cmd/piped/piped.go#L522-L532)

Here is where we define the options
ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planpreview/handler.go#L35-L40
ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planpreview/handler.go#L35-L40

Why is this needed:

It is better to make the users tunning the piped plan preview behavior with their parameter than just using the default settings, and we defined it already as well, so better to make it in use.

@khanhtc1202 khanhtc1202 added the kind/enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant