Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install fails on macos #9

Open
vladfi1 opened this issue Sep 6, 2024 · 4 comments
Open

pip install fails on macos #9

vladfi1 opened this issue Sep 6, 2024 · 4 comments

Comments

@vladfi1
Copy link

vladfi1 commented Sep 6, 2024

Trying to pip install pyenet fails on MacOS with

enet.c:785:10: fatal error: 'enet/types.h' file not found

I believe the issue is that the enet sources are not included in the tarball.

@NotAFile
Copy link
Member

NotAFile commented Sep 6, 2024

hm, it should be, theoretically, but perhaps something changed

@vladfi1
Copy link
Author

vladfi1 commented Sep 6, 2024

Could be related to #8 which changed the enet folder to a submodule.

@vladfi1
Copy link
Author

vladfi1 commented Sep 8, 2024

A workaround is to install directly from github (pip install git+https://github.com/piqueserver/pyenet) which correctly initializes the enet submodule before building.

vladfi1 added a commit to vladfi1/libmelee that referenced this issue Sep 8, 2024
vladfi1 added a commit to vladfi1/libmelee that referenced this issue Sep 8, 2024
@NotAFile
Copy link
Member

NotAFile commented Sep 8, 2024

Yeah, it sounds like the sdist just doesn't contain the enet files for whatever reason.

Which is confusing, because it's listed as a source folder, the wheels build fine and I don't think that was changed. @utf-4096 might have a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants