Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Sidebar doesn't adapt to dark version of theme #3468

Closed
aaronliu0130 opened this issue Mar 10, 2024 · 5 comments
Closed

[Bug] Sidebar doesn't adapt to dark version of theme #3468

aaronliu0130 opened this issue Mar 10, 2024 · 5 comments
Labels

Comments

@aaronliu0130
Copy link

Abstract

I use a theme, Alpenglow (aka. Firefox Radiance), which has a different background image under dark mode using the undocumented object "dark_theme" in its manifest.json. TST still uses the light mode background image under dark mode for its background.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Install Alpenglow or any theme with a different dark mode background image as specified in the abstract.
  4. Under "Dynamic Themes" of about:prefs, click "Force Dark Mode".

Expected result

The TST sidebar uses the background for dark mode, which, in Alpenglow's case, is purple.

Actual result

The sidebar is the light mode's orange-to-pink gradient.

Environment

  • Platform (OS): Win11
  • Version of Firefox: 115.8.0
  • Version (or revision) of Tree Style Tab: 3.9.22
@aaronliu0130
Copy link
Author

Actually, I don't think any dark mode style is respected except for the color of the selected tab, maybe. TST's tab text doesn't change in dark mode either.

@aaronliu0130 aaronliu0130 changed the title [Bug] Sidebar doesn't use dark version of background image from theme [Bug] Sidebar doesn't adapt to dark version of theme Mar 10, 2024
@irvinm
Copy link
Contributor

irvinm commented Mar 10, 2024

Known Firefox limitation discussed here: #2915

@aaronliu0130
Copy link
Author

oh wow

@aaronliu0130 aaronliu0130 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
@aaronliu0130
Copy link
Author

is there some way i could inspect the treestyletab sidebar to know what classes I should select to clone the alpenglow dark theme into it?

@irvinm
Copy link
Contributor

irvinm commented Mar 11, 2024

Yes ... follow these instructions: https://github.com/piroor/treestyletab/wiki/How-to-inspect-tree-of-tabs#how-to-inspect-the-sidebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants