[Bug] Private window bricked after 4.0.0/4.0.1 upgrade

[psofiterol]

Abstract

Steps to reproduce

1. Start Firefox with clean profile.
2. Install TST.
3. Make sure version is 4.0.1
4. Open a private widow and start opening tabs

Expected result (normal window)

Actual result (private window)

Environment

• Platform (OS): Ubuntu 22.04.4 LTS
• Version of Firefox: 123.0 (64-bit)
• Version (or revision) of Tree Style Tab: 4.0.1

[psofiterol]

Downgraded to 3.9.22 to temporarily fix this - worked as expected.

[piroor]

I cannot reproduce this, so there looks to be something missing steps to reproduce. Could you share exported configs of TST with me?

[psofiterol]

Hey 👋

Full version (skipped the lines about it being a snap, sry)

And the configs:
[email protected]

[SimonPilkington]

I encountered this after first updating from 3.9.22 to 4.0.1 but after restarting the browser it was fixed.

[ElhemEnohpi]

I got the same thing, starting today, with the 4.0.1 release, on Mac Firefox 123.0.1. My browser was open during the update to 4.0.1 overnight, and in the morning a private window I had open had the appearance similar to the "actual result" screenshot above. It was also not possible to scroll the tab sidebar. It seems to be resolved by restarting Firefox. Other non-private windows were not affected.

I was able to save the private window first, using Tab Session Manager. At first, restoring it also gave the broken appearance, but after restarting Firefox, I could restore it successfully.

[psofiterol]

right, thanks a lot @SimonPilkington & @ElhemEnohpi, I can confirm that restarting Firefox (after upgrading back to 4.0.1) has indeed fixed this issue!

@piroor not sure if I should just mark the issue as closed given the nature of the fix, leaving it up to you 🙏 (maybe good to leave it up for other ppl who might encounter this?)

[piroor]

Sadly I still cannot reproduce the problem after importing the config file #3475 (comment) . I've seen user style sheet in the config but I couldn't find out any possible triggers. Hmm...

Anyway restarting may be a workaround as some people reported, if something data cached by Firefox triggers problems.

[afontenot]

I also saw this and it went away after a restart.

Actually before restarting I downgraded and upgraded several times between the last 3.X and 4.01, and reproduced the issue multiple times whenever I returned to 4.01.

I also have a user style sheet (very small, just reduces the height of the tab bars), but removing it didn't fix the issue, even with a new private window.

[afontenot]

So, this is interesting. Now that I've restarted the browser, I see the reverse. When I force a downgrade to 3.9.22, the bug resurfaces! It then goes away again when I upgrade to 4.X.

Was able to reproduce on both photon and proton (the only two I tested).

[github-actions]

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

[psofiterol]

Closing this - the issue goes away after a Firefox restart.