Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Animations play when re-rendering tabs with virtual scrolling enabled #3572

Closed
awused opened this issue Jun 8, 2024 · 3 comments
Closed

Comments

@awused
Copy link

awused commented Jun 8, 2024

Abstract

I usually have animations on, but with virtual scrolling the tab elements animate into place when they re-render.

Steps to reproduce

  1. Keep animations and virtual scrolling enabled
  2. Open a lot of tabs and arrange them into trees
  3. Scroll up and down

Expected result

Scrolling up and down should not result in any animations playing, since no tabs are actually changing positions or states.

Actual result

Animations play as tabs translate themselves into position. This is often more apparent when scrolling down as scrolling up is more broken with virtual scrolling.

Environment

  • Platform (OS): Linux (Fedora 40, x11)
  • Version of Firefox: 126 and earlier
  • Version (or revision) of Tree Style Tab: 4.0.15
@awused
Copy link
Author

awused commented Jun 8, 2024

This is also way more apparent with outOfScreenTabsRenderingPages set to 0 instead of 1.

piroor added a commit that referenced this issue Jun 9, 2024
@piroor
Copy link
Owner

piroor commented Jun 9, 2024

I've found a bugs which can produce this kind problem (re-applying needless animation effect) and introduced patches to fix it. Could you try the development build?
https://github.com/piroor/treestyletab?tab=readme-ov-file#development-builds

@awused
Copy link
Author

awused commented Jun 9, 2024

Testing 4.0.17, it doesn't play the animations on scrolling anymore.

@awused awused closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants