Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] The context menu in the Floorp browser lacks native options for tabs #3629

Closed
Denpan1 opened this issue Sep 12, 2024 · 6 comments
Labels
enhancement help wanted stale no reaction got for a long term

Comments

@Denpan1
Copy link

Denpan1 commented Sep 12, 2024

Abstract

The context menu in the Floorp browser lacks native options specifically split window options. Here is a link to show how the feature in Floorp should work https://blog.ablaze.one/4502/2024-09-00/ .

Steps to see the situation

  1. Start Floorp v11.18.1 (64-bit) | Firefox: 128.3.0 with clean profile on Win10 22H2.
  2. Install TST v4.0.22.
  3. Open a few tabs.
  4. Left-click a tab to see the context menu.
  5. Try to find split window options in the menu.

Expected result

Having the split window options in the menu.

image

Actual (present) result

Those options are missing.
image

Environment

  • Platform (OS): Win10 22H2
  • Version of Firefox: 128.3.0 | Floorp Version 11.18.1 (64-bit)
  • Version (or revision) of Tree Style Tab: v4.0.22
@Denpan1 Denpan1 changed the title [Enhancement] (The context menu in the Floorp browser lacks native options for tabs) [Enhancement] The context menu in the Floorp browser lacks native options for tabs Sep 12, 2024
@piroor
Copy link
Owner

piroor commented Sep 12, 2024

Floorp specific context menu commands can be added and activated only on Floorp, if Floorp provide ability to call those features from WebExtensions addons via API.

Otherwise - if there is no such API - a forked version TST with Experiments may be a solution. Indeed current Waterfox's tabs sidebar is based on TST.

@Denpan1
Copy link
Author

Denpan1 commented Sep 12, 2024

Oh sorry i meant right-click in step 4

@Denpan1
Copy link
Author

Denpan1 commented Sep 12, 2024

Oh ok thank you

@piroor
Copy link
Owner

piroor commented Sep 12, 2024

Here are Experiments modules on Waterfox Sidebar:
https://github.com/BrowserWorks/Waterfox/tree/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/experiments
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/manifest.json#L247-L290

and here is the list of Waterfox specific modules depending on those Experiments APIs:
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/sidebar/index-ws.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/sidebar/tab-preview.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/sidebar/workaround-for-bug-1875100.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/background/index-ws.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/background/prefs.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/background/handle-autoplay-blocking.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/background/handle-chrome-menu-commands.js
https://github.com/BrowserWorks/Waterfox/blob/fc3cbba5b84902fce15dd968ceeb24498825fca2/waterfox/browser/components/sidebar/background/sharing-service.js

@github-actions github-actions bot added the stale no reaction got for a long term label Oct 13, 2024
Copy link

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

Copy link

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale no reaction got for a long term
Projects
None yet
Development

No branches or pull requests

2 participants