Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: Add PhotoSwipe lightbox to all linked images #214

Open
andreiungurianu opened this issue Sep 24, 2020 · 1 comment
Open

Images: Add PhotoSwipe lightbox to all linked images #214

andreiungurianu opened this issue Sep 24, 2020 · 1 comment

Comments

@andreiungurianu
Copy link

While working on the Gallery page for the Rosa 2 demo, @georgeolaru pointed out that we do not have a lightbox functionality for the images added in a gallery - either the default Gallery block or the Advanced Gallery block. This means that people can only click and be redirected to the full image url.

The proposal is to add this functionality - @georgeolaru mentioned PhotoSwipe as a potential solution.

@georgeolaru
Copy link
Member

georgeolaru commented Jun 24, 2022

I tested the PhotoSwipe (MIT license) script through the implementation of the Lightbox with PhotoSwipe WordPress plugin and it's working really well.

I think it would provide a better user experience if we integrate and slightly customize the PhotoSwipe script directly into the Nova Blocks plugin, leaving the users with advanced use-cases to use the above-mentioned plugin.

@georgeolaru georgeolaru changed the title Add a lightbox functionality for Gallery and Advanced Gallery block Images: Add PhotoSwipe lightbox to all linked images Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants