Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove User Gesture popup modal on Sidebar #9165

Open
Pashaminkovsky opened this issue Sep 17, 2024 · 5 comments
Open

Remove User Gesture popup modal on Sidebar #9165

Pashaminkovsky opened this issue Sep 17, 2024 · 5 comments
Assignees
Labels
bug Something isn't working customer Required for a customer projct specification required

Comments

@Pashaminkovsky
Copy link
Collaborator

MV3 requires a user gesture before opening the sidepanel. This is causing friction with a number of use cases (e.g. compliance).

This was available in MV2 but broke in MV3. Are there any workarounds to the user gesture requirement that we can implement?

Relevant discussions:

  1. Discussion with the Chrome team: https://groups.google.com/a/chromium.org/g/chromium-extensions/c/WRGFOAHxoaY/m/nPkUkJlqAAAJ?utm_medium=email&utm_source=footer
  2. W3C proposal: Add support for opening side panel without user interaction w3c/webextensions#472
@Pashaminkovsky Pashaminkovsky added the bug Something isn't working label Sep 17, 2024
@twschiller twschiller added customer Required for a customer projct specification required labels Sep 17, 2024
@twschiller
Copy link
Contributor

twschiller commented Sep 18, 2024

Adding "specification required flag" because, as per the discussions/proposal we don't have a technical workaround for this. So it needs clarification before engineering picks it up

One option that has been floated is to open the sidebar on all tabs (i.e., keep it globally open) to avoid having to reopen it. But that solution may not be suitable

Another option would be to re-add support for an embedded sidebar (aka MV2 sidebar) to better support these use cases

@Pashaminkovsky
Copy link
Collaborator Author

@mthek10 would either of the workarounds that Todd mentioned^ suffice in the meantime?

@twschiller can you share documentation so I can read up on the MV2 embedded sidebar?

@twschiller
Copy link
Contributor

twschiller commented Sep 18, 2024

@twschiller can you share documentation so I can read up on the MV2 embedded sidebar?

The MV2 sidebar isn't a Chrome affordance. It was a sidebar we implemented. It injects a frame into the page and attempts (sometimes unsuccessfully, due to absolute element positioning) to shift the main content over

You can find videos of the old behavior on our YouTube channel: https://www.youtube.com/watch?v=iL7IXGFt1Ys

@Pashaminkovsky
Copy link
Collaborator Author

Next steps: @Pashaminkovsky to sync w/ @mthek10 on what we can do here

@Pashaminkovsky Pashaminkovsky self-assigned this Sep 20, 2024
@twschiller
Copy link
Contributor

twschiller commented Sep 26, 2024

For the decision tree/quality/compliance use cases in question, one approach we might take is modifying the "Display Temporary Information" brick to be able to show the panel in an embedded sidebar. That embedded sidebar could be like the modal and only contain the panel content and not the mod launcher, etc.

That could get around the engineering concern of having to maintain 2 completely different sidebar protocols, as we could just use the existing modal code but change how the iframe is added to the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Required for a customer projct specification required
Projects
None yet
Development

No branches or pull requests

2 participants