From c145777835391096ed9d9f6d749cc3e70f794690 Mon Sep 17 00:00:00 2001 From: Misha Holtz <36575242+mnholtz@users.noreply.github.com> Date: Thu, 3 Oct 2024 13:11:23 -0700 Subject: [PATCH 1/4] add entry for BrickCommentsUpdate --- src/telemetry/lexicon.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/telemetry/lexicon.ts b/src/telemetry/lexicon.ts index e5a476d9d..8f1a1bb45 100644 --- a/src/telemetry/lexicon.ts +++ b/src/telemetry/lexicon.ts @@ -86,6 +86,12 @@ export const lexicon: LexiconMap = { 'Triggered when a user successfully adds a brick to a Mod in the Page Editor via clicking "Add" or "Add brick" in the Add Brick modal.', tags: [LexiconTags.PAGE_EDITOR], }, + BRICK_COMMENTS_UPDATE: { + description: + "Triggered when a user updates the brick comment in the Data Panel 'comments' tab in the Page Editor. More specifically," + + "when a user modifies the comment and leaves the field.", + tags: [LexiconTags.PAGE_EDITOR], + }, }; /** From 93355fe89989b5eedfa294036995ceec137ccfa4 Mon Sep 17 00:00:00 2001 From: Misha Holtz <36575242+mnholtz@users.noreply.github.com> Date: Thu, 3 Oct 2024 13:12:07 -0700 Subject: [PATCH 2/4] tweak description --- src/telemetry/lexicon.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/telemetry/lexicon.ts b/src/telemetry/lexicon.ts index 8f1a1bb45..42ecb41e2 100644 --- a/src/telemetry/lexicon.ts +++ b/src/telemetry/lexicon.ts @@ -88,7 +88,7 @@ export const lexicon: LexiconMap = { }, BRICK_COMMENTS_UPDATE: { description: - "Triggered when a user updates the brick comment in the Data Panel 'comments' tab in the Page Editor. More specifically," + + "Triggered when a user updates the brick comment in the 'comments' tab of the Data Panel in the Page Editor. More specifically, " + "when a user modifies the comment and leaves the field.", tags: [LexiconTags.PAGE_EDITOR], }, From ee53f02927d583b16716dabf900dec0281d671e4 Mon Sep 17 00:00:00 2001 From: Misha Holtz <36575242+mnholtz@users.noreply.github.com> Date: Thu, 3 Oct 2024 13:20:48 -0700 Subject: [PATCH 3/4] add entry for BrowserActionRestrictedUrl --- src/telemetry/lexicon.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/telemetry/lexicon.ts b/src/telemetry/lexicon.ts index 42ecb41e2..5678908bd 100644 --- a/src/telemetry/lexicon.ts +++ b/src/telemetry/lexicon.ts @@ -92,6 +92,11 @@ export const lexicon: LexiconMap = { "when a user modifies the comment and leaves the field.", tags: [LexiconTags.PAGE_EDITOR], }, + BROWSER_ACTION_RESTRICTED_URL: { + description: + "Reported when a user sees the restricted webpage warning 'PixieBrix cannot access this page' when opening the " + + "PixieBrix sidebar on a restricted page, e.g. the Extension Console or a new browser tab.", + }, }; /** From e8a9569ca6540d64107d48a73e0b00be5c61e796 Mon Sep 17 00:00:00 2001 From: Misha Holtz <36575242+mnholtz@users.noreply.github.com> Date: Thu, 3 Oct 2024 13:26:54 -0700 Subject: [PATCH 4/4] add entry for CustomUserEvent --- src/telemetry/lexicon.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/telemetry/lexicon.ts b/src/telemetry/lexicon.ts index 5678908bd..fa34c78ac 100644 --- a/src/telemetry/lexicon.ts +++ b/src/telemetry/lexicon.ts @@ -23,6 +23,7 @@ const LexiconTags = { PAGE_EDITOR: "page editor", MOD_ACTIVATION: "mod activation", EXTENSION_CONSOLE: "extension console", + MOD_RUNTIME: "mod runtime", } as const; type LexiconTag = ValueOf; @@ -96,6 +97,13 @@ export const lexicon: LexiconMap = { description: "Reported when a user sees the restricted webpage warning 'PixieBrix cannot access this page' when opening the " + "PixieBrix sidebar on a restricted page, e.g. the Extension Console or a new browser tab.", + tags: [LexiconTags.MOD_RUNTIME], + }, + CUSTOM_USER_EVENT: { + description: + "Event reported from the 'Send Telemetry' brick in a mod. Mod developers can customize the `eventName` " + + "property and add additional properties to this event at will.", + tags: [LexiconTags.MOD_RUNTIME], }, };