Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned state not visible when maximized #56

Open
pjeby opened this issue Jun 8, 2024 · 0 comments
Open

Pinned state not visible when maximized #56

pjeby opened this issue Jun 8, 2024 · 0 comments

Comments

@pjeby
Copy link
Owner

pjeby commented Jun 8, 2024

When a tab is maximized, there's no way to see its pinned state. The leaf's .tabHeaderStatusPinEl needs to be moved from the .tabHeaderStatusContainerEl to its view header, and back again when unmaximized. The .setPinned() method needs to be wrapped so that fresh pins are moved right away.

This will probably require refactoring the existing maximize implementation (which is something of a hack). It might also make sense to move the tab's close "x" (.tabHeaderCloseEl) onto the view header as well, perhaps as the last action before the "more" menu items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant