From e808920da05ae22b46a98339158a641c2feb5bcd Mon Sep 17 00:00:00 2001 From: Cassondra Foesch Date: Tue, 6 Feb 2024 08:31:27 +0000 Subject: [PATCH] remove unnecessary block, and explain why the one added is necessary --- client.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/client.go b/client.go index ee372f07..b30159b4 100644 --- a/client.go +++ b/client.go @@ -439,6 +439,7 @@ func (c *Client) Lstat(p string) (os.FileInfo, error) { } attr, _, err := unmarshalAttrs(data) if err != nil { + // avoid returning a valid value from fileInfoFromStats if err != nil. return nil, err } return fileInfoFromStat(attr, path.Base(p)), nil @@ -667,9 +668,6 @@ func (c *Client) stat(path string) (*FileStat, error) { return nil, &unexpectedIDErr{id, sid} } attr, _, err := unmarshalAttrs(data) - if err != nil { - return nil, err - } return attr, err case sshFxpStatus: return nil, normaliseError(unmarshalStatus(id, data))