From 22cb31cc782603bf5b0c7d80d37a2c0e27150682 Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Mon, 29 Aug 2022 17:12:50 +0600 Subject: [PATCH 1/2] pkp/pkp-lib#7725 editorial decision constants synced up --- classes/decision/Decision.php | 58 ++--------------------------------- 1 file changed, 2 insertions(+), 56 deletions(-) diff --git a/classes/decision/Decision.php b/classes/decision/Decision.php index 92f5db8928..ffb3a96542 100644 --- a/classes/decision/Decision.php +++ b/classes/decision/Decision.php @@ -23,61 +23,7 @@ use PKP\decision\Decision as BaseDecision; -/** - * The decision constants are not used in OPS, but they are required - * in order to prevent errors in the pkp-lib code. They should be - * removed once the constants have been synced across OJS/OMP and moved - * into pkp-lib. - * - * @see https://github.com/pkp/pkp-lib/issues/7725 - */ class Decision extends BaseDecision { - /** @deprecated */ - public const ACCEPT = 1; - - /** @deprecated */ - public const PENDING_REVISIONS = 2; - - /** @deprecated */ - public const RESUBMIT = 3; - - /** @deprecated */ - public const DECLINE = 4; - - /** @deprecated */ - public const SEND_TO_PRODUCTION = 7; - - /** @deprecated */ - public const EXTERNAL_REVIEW = 8; - - /** @deprecated */ - public const RECOMMEND_ACCEPT = 11; - - /** @deprecated */ - public const RECOMMEND_PENDING_REVISIONS = 12; - - /** @deprecated */ - public const RECOMMEND_RESUBMIT = 13; - - /** @deprecated */ - public const RECOMMEND_DECLINE = 14; - - /** @deprecated */ - public const NEW_EXTERNAL_ROUND = 16; - - /** @deprecated */ - public const REVERT_DECLINE = 17; - - /** @deprecated */ - public const SKIP_EXTERNAL_REVIEW = 19; - - /** @deprecated */ - public const BACK_TO_REVIEW = 20; - - /** @deprecated */ - public const BACK_TO_COPYEDITING = 21; - - /** @deprecated */ - public const BACK_TO_SUBMISSION_FROM_COPYEDITING = 22; -} + +} \ No newline at end of file From f19684b53e1e2db081ef4c67d3239e5c3bfffe13 Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Mon, 29 Aug 2022 17:13:22 +0600 Subject: [PATCH 2/2] pkp/pkp-lib#7725 Submodule Update ##touhidurabir/i7725_main## --- lib/pkp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pkp b/lib/pkp index 1bf2782e82..e9e0bb319e 160000 --- a/lib/pkp +++ b/lib/pkp @@ -1 +1 @@ -Subproject commit 1bf2782e82ec9cdd582f786ba8c8b0f59eba528d +Subproject commit e9e0bb319e2517d9037d7097885bdef80eaa7960