Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Submission listing: api dependencies #10011

Open
11 of 21 tasks
jardakotesovec opened this issue Jun 3, 2024 · 5 comments
Open
11 of 21 tasks

[Meta] Submission listing: api dependencies #10011

jardakotesovec opened this issue Jun 3, 2024 · 5 comments
Assignees
Labels
Meta Issue An issue that groups and describes a collection of other issues.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Jun 3, 2024

Meta issue just to track various outstanding issues for API adjustments that are required to power new submission
listing.

Bold are priority issues.

Missing data

Views adjustments

Other submission listing backend Improvements

@Vitaliy-1
Copy link
Collaborator

@jardakotesovec, can you describe in more details this one:

as reviewer - I am getting all the reviewAssignments in the /submission/ endpoint. Thats needs to be adjusted to only assigned and open ones - #9965

I'm unable to reproduce the problem. I'm calling ...publicknowledge/api/v1/submissions as a reviewer and don't retrieve any reviews. Response example:

{
    "itemsMax": 8,
    "items": [
        {
            "_href": "http://localhost:8000/index.php/publicknowledge/api/v1/submissions/19",
            "contextId": 1,
            "currentPublicationId": 20,
            "dateLastActivity": "2024-06-06 05:35:00",
            "dateSubmitted": "2024-06-06 05:34:30",
            "editorAssigned": true,
            "id": 19,
            "lastModified": "2024-06-06 05:34:30",
            "locale": "en",
            "publications": [
                {
                    "_href": "http://localhost:8000/index.php/publicknowledge/api/v1/submissions/19/publications/20",
                    "authorsString": "",
                    "authorsStringIncludeInBrowse": "",
                    "authorsStringShort": "",
                    "categoryIds": [],
                    "coverImage": {
                        "en": null,
                        "fr_CA": null
                    },
                    "datePublished": null,
                    "doiObject": null,
                    "fullTitle": {
                        "en": "Finocchiaro: Arguments About Arguments",
                        "fr_CA": ""
                    },
                    "galleys": [],
                    "id": 20,
                    "locale": "en",
                    "pages": null,
                    "prefix": {
                        "en": "",
                        "fr_CA": ""
                    },
                    "primaryContactId": 28,
                    "pub-id::publisher-id": null,
                    "sectionId": 2,
                    "status": 1,
                    "submissionId": 19,
                    "subtitle": {
                        "en": "",
                        "fr_CA": ""
                    },
                    "title": {
                        "en": "Finocchiaro: Arguments About Arguments",
                        "fr_CA": ""
                    },
                    "urlPublished": "http://localhost:8000/index.php/publicknowledge/en/article/view/19/version/20",
                    "version": 1
                }
            ],
            "recommendationsIn": null,
            "reviewersNotAssigned": true,
            "revisionsRequested": false,
            "revisionsSubmitted": false,
            "scheduledIn": null,
            "stageId": 4,
            "status": 1,
            "statusLabel": "Queued",
            "submissionProgress": "",
            "urlAuthorWorkflow": "http://localhost:8000/index.php/publicknowledge/en/authorDashboard/submission/19",
            "urlEditorialWorkflow": "http://localhost:8000/index.php/publicknowledge/en/workflow/access/19",
            "urlPublished": "http://localhost:8000/index.php/publicknowledge/en/article/view/19",
            "urlSubmissionWizard": "http://localhost:8000/index.php/publicknowledge/en/submission?id=19",
            "urlWorkflow": "http://localhost:8000/index.php/publicknowledge/en/reviewer/submission/19"
        },
        ...
    ]
}

@jardakotesovec
Copy link
Contributor Author

@Vitaliy-1 I meant endpoint for specific submission - index.php/publicknowledge/api/v1/submissions/12

@Vitaliy-1
Copy link
Collaborator

Author and reviewers have access to that endpoint, which includes information about reviews. If the review isn't open, the reviewer name is anonymised (the same for the author name for double-blind reviews). Do you think the rest of data about the review is also sensitive?

@Vitaliy-1
Copy link
Collaborator

example of data:

{
      "id": 27,
      "isCurrentUserAssigned": false,
      "statusId": 0,
      "status": "Waiting for a response from the reviewer.",
      "dateDue": "2024-07-04",
      "dateResponseDue": "2024-07-04",
      "dateConfirmed": null,
      "dateCompleted": null,
      "dateAssigned": "2024-06-06",
      "round": 1,
      "roundId": 13,
      "recommendation": null,
      "dateCancelled": null,
      "reviewerFullName": "",
      "reviewMethod": 2
  }

@jardakotesovec
Copy link
Contributor Author

@Vitaliy-1 Alright, not sure whether someone would find these sensitive.

@Vitaliy-1 Vitaliy-1 added the Meta Issue An issue that groups and describes a collection of other issues. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Issue An issue that groups and describes a collection of other issues.
Projects
None yet
Development

No branches or pull requests

3 participants