-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Submission listing: api dependencies #10011
Comments
@jardakotesovec, can you describe in more details this one:
I'm unable to reproduce the problem. I'm calling {
"itemsMax": 8,
"items": [
{
"_href": "http://localhost:8000/index.php/publicknowledge/api/v1/submissions/19",
"contextId": 1,
"currentPublicationId": 20,
"dateLastActivity": "2024-06-06 05:35:00",
"dateSubmitted": "2024-06-06 05:34:30",
"editorAssigned": true,
"id": 19,
"lastModified": "2024-06-06 05:34:30",
"locale": "en",
"publications": [
{
"_href": "http://localhost:8000/index.php/publicknowledge/api/v1/submissions/19/publications/20",
"authorsString": "",
"authorsStringIncludeInBrowse": "",
"authorsStringShort": "",
"categoryIds": [],
"coverImage": {
"en": null,
"fr_CA": null
},
"datePublished": null,
"doiObject": null,
"fullTitle": {
"en": "Finocchiaro: Arguments About Arguments",
"fr_CA": ""
},
"galleys": [],
"id": 20,
"locale": "en",
"pages": null,
"prefix": {
"en": "",
"fr_CA": ""
},
"primaryContactId": 28,
"pub-id::publisher-id": null,
"sectionId": 2,
"status": 1,
"submissionId": 19,
"subtitle": {
"en": "",
"fr_CA": ""
},
"title": {
"en": "Finocchiaro: Arguments About Arguments",
"fr_CA": ""
},
"urlPublished": "http://localhost:8000/index.php/publicknowledge/en/article/view/19/version/20",
"version": 1
}
],
"recommendationsIn": null,
"reviewersNotAssigned": true,
"revisionsRequested": false,
"revisionsSubmitted": false,
"scheduledIn": null,
"stageId": 4,
"status": 1,
"statusLabel": "Queued",
"submissionProgress": "",
"urlAuthorWorkflow": "http://localhost:8000/index.php/publicknowledge/en/authorDashboard/submission/19",
"urlEditorialWorkflow": "http://localhost:8000/index.php/publicknowledge/en/workflow/access/19",
"urlPublished": "http://localhost:8000/index.php/publicknowledge/en/article/view/19",
"urlSubmissionWizard": "http://localhost:8000/index.php/publicknowledge/en/submission?id=19",
"urlWorkflow": "http://localhost:8000/index.php/publicknowledge/en/reviewer/submission/19"
},
...
]
} |
@Vitaliy-1 I meant endpoint for specific submission - index.php/publicknowledge/api/v1/submissions/12 |
Author and reviewers have access to that endpoint, which includes information about reviews. If the review isn't open, the reviewer name is anonymised (the same for the author name for double-blind reviews). Do you think the rest of data about the review is also sensitive? |
example of data: {
"id": 27,
"isCurrentUserAssigned": false,
"statusId": 0,
"status": "Waiting for a response from the reviewer.",
"dateDue": "2024-07-04",
"dateResponseDue": "2024-07-04",
"dateConfirmed": null,
"dateCompleted": null,
"dateAssigned": "2024-06-06",
"round": 1,
"roundId": 13,
"recommendation": null,
"dateCancelled": null,
"reviewerFullName": "",
"reviewMethod": 2
} |
@Vitaliy-1 Alright, not sure whether someone would find these sensitive. |
Meta issue just to track various outstanding issues for API adjustments that are required to power new submission
listing.
Bold are priority issues.
Missing data
/_submissions
endpoint in reviewAssignments array - Enhance submission schema with review assignment data #9965_submissions/reviewerAssignments
- Fetch submission' title for the reviewer assignments list #9825Views adjustments
Other submission listing backend Improvements
The text was updated successfully, but these errors were encountered: