Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable skipped tests for 3.5 #10115

Closed
jonasraoni opened this issue Jun 24, 2024 · 4 comments
Closed

Reenable skipped tests for 3.5 #10115

jonasraoni opened this issue Jun 24, 2024 · 4 comments
Assignees
@jardakotesovec
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.5 Internal

Comments

@jonasraoni
Copy link
Contributor

Describe the bug
At #10061, a couple of tests have been disabled on the main branch for all of the applications, it's needed to get them back.

See commits:
3fd04e5
pkp/ojs@9518b9e

What application are you using?
OJS/main
@jonasraoni jonasraoni added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jun 24, 2024
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Jun 24, 2024
@jardakotesovec
Copy link
Contributor

@jonasraoni let me know if you need any help with this.. debugging cypress tests day&night..

@jonasraoni
Copy link
Contributor Author

Feel free to take a look! I've already assigned too many tasks to myself 😂

I guess it's a Cypress concurrency issue. When I logged into the GitHub machine and executed the test individually, it worked. Also, on a couple of PRs, it has a non-stable behavior (here for example, 2 worked, 3 failed: https://github.com/pkp/omp/actions/runs/9590188958), but suddenly it started to fail always.

@jardakotesovec jardakotesovec self-assigned this Jun 24, 2024
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Nov 11, 2024
@jardakotesovec
pkp#10115 Re-enable skipped cypress tests
a68e05f
jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue Nov 11, 2024
@jardakotesovec
pkp/pkp-lib#10115 Re-enable skipped cypress tests
690d8e6
jardakotesovec added a commit to jardakotesovec/ops that referenced this issue Nov 11, 2024
@jardakotesovec
pkp/pkp-lib#10115 Re-enable skipped cypress tests
7fd870b
jardakotesovec added a commit that referenced this issue Nov 11, 2024
@jardakotesovec
#10115 Re-enable skipped cypress tests
72087f4
jardakotesovec added a commit to pkp/ojs that referenced this issue Nov 11, 2024
@jardakotesovec
pkp/pkp-lib#10115 Re-enable skipped cypress tests
4877f10
jardakotesovec added a commit to pkp/ops that referenced this issue Nov 11, 2024
@jardakotesovec
pkp/pkp-lib#10115 Re-enable skipped cypress tests
13e58a5
@jardakotesovec
Copy link
Contributor

@jonasraoni Just got to this one. Interestingly these tests are passing just fine after re-enabling :-). So it now should be all enabled & passing on main.

Closing

@jonasraoni
Copy link
Contributor Author

Great 😁

jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Nov 14, 2024
@jardakotesovec
pkp#10115 Re-enable skipped cypress tests
47a0851
@jardakotesovec jardakotesovec mentioned this issue Nov 14, 2024
Open
GaziYucel pushed a commit to GaziYucel/ojs that referenced this issue Nov 15, 2024
@jardakotesovec @GaziYucel
pkp/pkp-lib#10115 Re-enable skipped cypress tests
17fd818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jardakotesovec jardakotesovec

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@jonasraoni @jardakotesovec