Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMP] Add option to disable validation in Onix export plugin #10132

Closed
kaitlinnewson opened this issue Jun 26, 2024 · 10 comments
Closed

[OMP] Add option to disable validation in Onix export plugin #10132

kaitlinnewson opened this issue Jun 26, 2024 · 10 comments
Assignees
Milestone

Comments

@kaitlinnewson
Copy link
Member

Currently validation is always enforced in the Onix export plugin, but we want to add the option to disable it in order to ensure that the export can still be done when there may be metadata gaps.

This currently exists in some other plugins, such as the DOAJ Export plugin.

What application are you using?
OMP 3.3/3.4/main

Additional information

Example from the DOAJ plugin:

Screenshot 2024-06-26 at 1 20 10 PM

@kaitlinnewson
Copy link
Member Author

kaitlinnewson commented Jul 4, 2024

PRs for review, and will be forward-ported once approved:

PRs for locale key changes (key from OJS to pkp-lib):

If you want to force validation to break in the exports, you can replace the xsd schema files in plugins/importexport/onix30 with the latest versions (3.0.8).

@bozana would you be able to review?

One thing I had a question about is in the locale files. I copied over a locale key that is currently in OJS only - does it make sense to move this key into pkp-lib, or are duplicate keys in OJS and OMP acceptable? If duplicates are okay, then I can copy over the translations as well.

@bozana
Copy link
Collaborator

bozana commented Jul 10, 2024

Hi @kaitlinnewson, I was traveling but am now back and will take a look at this soon... Thanks!

@kaitlinnewson
Copy link
Member Author

Thanks @bozana - I'm looking at moving the locale key to pkp-lib so not ready to merge yet, but if you have time to review that would be great

kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 10, 2024
kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 10, 2024
kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 10, 2024
@kaitlinnewson
Copy link
Member Author

@bozana I've made the locale key changes and added them to the list of PRs above, ready for review on OMP 3_3_0

@bozana
Copy link
Collaborator

bozana commented Jul 11, 2024

Hi @kaitlinnewson, great! All looks good.
When we make bigger changes to the locale keys, we ask Alec to copy the newest translations from Weblate -- so that there are no conflicts when introducing the new changes.
@asmecher, could you copy the newest translations to OJS and PKP-LIB stable-3_3_0, stable-3_4_0 and main?
@kaitlinnewson, you would then need to rebase and then we can merge.
Thanks a lot!

@bozana
Copy link
Collaborator

bozana commented Jul 11, 2024

@kaitlinnewson, @asmecher has updated all locales. Could you please rebase? Then we will merge.
Thanks a lot!

kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 11, 2024
kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 11, 2024
@kaitlinnewson
Copy link
Member Author

@bozana rebase is done for 3_4_0 and main (no changes in 3_3_0) - let me know if you see any issues as I haven't used rebasing very much before.

Working on forward-porting now and will update when that's done.

kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 12, 2024
bozana added a commit that referenced this issue Jul 15, 2024
#10132 move plugin validation locale key for use in omp
bozana added a commit to pkp/ojs that referenced this issue Jul 15, 2024
pkp/pkp-lib#10132 move plugin validation locale key for use in omp
bozana added a commit that referenced this issue Jul 15, 2024
#10132 move plugin validation locale key for use in omp
bozana added a commit to pkp/omp that referenced this issue Jul 15, 2024
pkp/pkp-lib#10132 add checkbox for validation in Onix export plugin
bozana added a commit to pkp/ojs that referenced this issue Jul 15, 2024
pkp/pkp-lib#10132 move plugin validation locale key for use in omp
bozana added a commit that referenced this issue Jul 15, 2024
#10132 move plugin validation locale key for use in omp
bozana added a commit to pkp/ojs that referenced this issue Jul 15, 2024
pkp/pkp-lib#10132 move plugin validation locale key for use in omp
@bozana
Copy link
Collaborator

bozana commented Jul 15, 2024

Hi @kaitlinnewson, I have just merged everything from here. Would you now like to port OMP changes to stable-3_4_0 and main?

kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 16, 2024
kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Jul 16, 2024
@kaitlinnewson
Copy link
Member Author

@bozana I've ported to 3_4_0 and main and added them to the list above. The PRs are slightly different from the changes in 3_3_0 as some things were moved to being handled in pkp-lib between the versions.

bozana added a commit that referenced this issue Jul 17, 2024
#10132 add checkbox for validation in Onix export plugin
bozana added a commit to pkp/omp that referenced this issue Jul 17, 2024
pkp/pkp-lib#10132 add checkbox for validation in Onix export plugin
bozana added a commit that referenced this issue Jul 17, 2024
#10132 add checkbox for validation in Onix export plugin
bozana added a commit to pkp/omp that referenced this issue Jul 17, 2024
pkp/pkp-lib#10132 add checkbox for validation in Onix export plugin
@bozana
Copy link
Collaborator

bozana commented Jul 17, 2024

All merged, thus closing...

@bozana bozana closed this as completed Jul 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in DOAB / OMP Data Exchange Jul 17, 2024
@asmecher asmecher added this to the 3.3.0-20 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants