-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OMP] Add option to disable validation in Onix export plugin #10132
Comments
Hi @kaitlinnewson, I was traveling but am now back and will take a look at this soon... Thanks! |
Thanks @bozana - I'm looking at moving the locale key to pkp-lib so not ready to merge yet, but if you have time to review that would be great |
@bozana I've made the locale key changes and added them to the list of PRs above, ready for review on OMP 3_3_0 |
Hi @kaitlinnewson, great! All looks good. |
@kaitlinnewson, @asmecher has updated all locales. Could you please rebase? Then we will merge. |
@bozana rebase is done for 3_4_0 and main (no changes in 3_3_0) - let me know if you see any issues as I haven't used rebasing very much before. Working on forward-porting now and will update when that's done. |
#10132 move plugin validation locale key for use in omp
pkp/pkp-lib#10132 move plugin validation locale key for use in omp
#10132 move plugin validation locale key for use in omp
pkp/pkp-lib#10132 add checkbox for validation in Onix export plugin
pkp/pkp-lib#10132 move plugin validation locale key for use in omp
#10132 move plugin validation locale key for use in omp
pkp/pkp-lib#10132 move plugin validation locale key for use in omp
Hi @kaitlinnewson, I have just merged everything from here. Would you now like to port OMP changes to stable-3_4_0 and main? |
@bozana I've ported to 3_4_0 and main and added them to the list above. The PRs are slightly different from the changes in 3_3_0 as some things were moved to being handled in pkp-lib between the versions. |
#10132 add checkbox for validation in Onix export plugin
pkp/pkp-lib#10132 add checkbox for validation in Onix export plugin
#10132 add checkbox for validation in Onix export plugin
pkp/pkp-lib#10132 add checkbox for validation in Onix export plugin
All merged, thus closing... |
Currently validation is always enforced in the Onix export plugin, but we want to add the option to disable it in order to ensure that the export can still be done when there may be metadata gaps.
This currently exists in some other plugins, such as the DOAJ Export plugin.
What application are you using?
OMP 3.3/3.4/main
Additional information
Example from the DOAJ plugin:
The text was updated successfully, but these errors were encountered: